Re: [PATCH,HURD] Fix root device passing

[Samuel Thibault]

Robert Millan, le Mon 02 Nov 2009 20:11:07 +0100, a écrit :
> On Mon, Nov 02, 2009 at 07:53:36PM +0100, Samuel Thibault wrote:
> > Colin Watson, le Mon 02 Nov 2009 18:50:43 +0000, a écrit :
> > > 'multiboot ${kernel} root=device:${GRUB_DEVICE#/dev/}' would be simpler
> > > and quicker.
> > 
> > And will not work on some systems.
> 
> I guess at least in the GNU system it's safe to assume that /bin/bash is
> available? ;-)

bash, yes, but remember that /bin/sh could point to something else than
bash.  I believe we can however assume a /bin/sh that supports such
substitution on the GNU system (note that dash used to not support it
previously).

> Note: we follow the convention of using hi case for global variables and
> low case for private ones, so at the least I'd s/ROOT_DEVICE/root_device/
> here.

Ok, anyway it disappears.

Samuel