[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Refer to kernel of FreeBSD as "kFreeBSD"
|
From: |
Colin Watson |
|
Subject: |
Re: [PATCH] Refer to kernel of FreeBSD as "kFreeBSD" |
|
Date: |
Wed, 14 Oct 2009 13:43:05 +0100 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Oct 14, 2009 at 02:28:48PM +0200, Robert Millan wrote:
> Note: Some string lengths were hardcoded, and they're being replaced with
> sizeof() statements. I triple-checked them for off-by-one mistakes, but it
> doesn't hurt if someone else reviews it. Please avoid hardcoding constant
> string lengths! It makes it more error-prone to change those strings later.
I reviewed the string code and it looks fine.
--
Colin Watson address@hidden