grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Create environment block safely


From: Colin Watson
Subject: Re: [PATCH] Create environment block safely
Date: Thu, 1 Oct 2009 19:22:47 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Wed, Sep 30, 2009 at 11:54:30PM +0100, Colin Watson wrote:
> If grub-editenv create is interrupted, it's theoretically possible for
> it to create an incomplete block that future grub-editenv calls won't
> recognise. It would be better for it to atomically create either a
> complete block or nothing. Any objections?
> 
> 2009-09-30  Colin Watson  <address@hidden>
> 
>         * util/grub-editenv.c (create_envblk_file): Write new block with a
>         .new suffix and then rename it into place, to ensure atomic
>         creation.

I've gone ahead and committed this, since it's straightforward enough.

-- 
Colin Watson                                       address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]