Re: [GITGRUB] FB driver for EFI

[Vladimir 'phcoder' Serbinenko]

+grub_uint32_t uga_fb;
+grub_uint32_t uga_pitch;
+
Why are these variables global? They should be either static or
properly prefixed.

Have you tried linux_video_setup as present in i386/linux.c in
i386/efi/linux.c ? It would be nice if we could share more code
between these 2 files. If it works and you judge that  i386/linux.c
and i386/efi/linux.c are similar enough you can merge them using
ifdef's when needed

-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git