Re: Fwd: [PATCH 1/2] Framebuffer split

[Michal Suchanek]

Hello,

both in the previous complete patch and Vladimir's git repository
introduce a grub_video_rect_t type.

Is there some intention to change the interface to use this structure?

I was looking at the the various places that use points and
rectangles. It's quite inconsistent and unclear now.

There is an anonymous viewport structure inside render target which is
the same as the rectangle type. Many coordinates and sizes are signed
and many are unsigned leading to numerous casts and/or signed vs
unsigned comparison warnings.

The blit functions take a rectangle and a point specified as six
separate integers which makes it somewhat unclear what is what.


The other thing that bothers me is that the video drivers fill in the
render target structure during video initialization.

In my view the render target structure should not be public. The video
driver should fill in the video mode structure and then call a
function that fills in render target based on video mode and video
data (framebuffer memory). This code is currently replicated
needlessly in the vbe and sdl drivers.

Bitmaps could be created in the same way.

Thanks

Michal