Re: [PATCH] xfs bug fix

[Pavel Roskin]

On Sun, 2009-07-19 at 17:04 +0800, Bean wrote:

> Oh nice catch, it's indeed a serious problem, this patch should fix it.

Please don't add any trailing whitespace.  Also please avoid formatting
changes in the patches posted for review.  If you find formatting in
xfs.c too bad, you can indent the original file and commit it without
review (just make sure it didn't get even worse), and then make a patch
to the indented file.

I think using "struct grub_xfs_inode inode[0]" in "struct
grub_fshelp_node" is unwarranted.  This notation assumes that there is a
variable amount of inodes there.  In fact, there is always one inode,
but of variable size.

Instead, I would replace raw[156] with raw[0] and
extents[XFS_INODE_EXTENTS] with extents[0].

Conversion of diropen to a pointer also seems unneeded.  It's better to
allocate memory in one piece.  It simplifies error handling and keeps
the code short.  If a bigger chunk of memory needs to be allocated, use
grub_realloc().

Please avoid non-descriptive labels like "fail_2".

-- 
Regards,
Pavel Roskin