Re: [PATCH] enable buildable targets by default

[Pavel Roskin]

On Sat, 2009-07-18 at 23:38 +0200, Vladimir 'phcoder' Serbinenko wrote:

> > I fully agree.  The idea with my proposal (we talked this on IRC, I think)
> > was to simplify things, so I proposed that we enable everything so we don't
> > have to provide flags, etc.
> The main pro was to avoid frequent breakage as we experienced with grub-emu.

I just use a script to build grub for all supported platforms with all
supported options.  It's quite good for finding such errors.  As it
stands now, there are no errors and no warnings.  But it took a while to
fix everything.

I think we should eventually revert to not building debug tools by
default.

> > I prefer if we got rid of the flags, or at least most of them (lumping them
> > together with a flag to disable debug tools or so),

I agree.  grub-emu, grub-fstest and efiemu are debug tools.  Neither is
needed for normal operation on any platform.

> I'm undecided on this point. On one hand they can be useful if used
> correctly on the other hand if removing them would avoid users doing
> errors

What kind of errors do you mean?

> > and remove the summary
> > message as well.
> >
> However I really think summary message should remain. It avoids
> developpers to scroll through tons of messages to find out if the part
> they need is built and if it isn't why

The summary message is OK with me, be we should keep it short and to the
point.

-- 
Regards,
Pavel Roskin