Re: [PATCH] Caseless UUID comparsion in search command

[Arthur Marsh]

Pavel Roskin wrote, on 08/07/09 15:56:
> On Tue, 2009-07-07 at 16:21 +0930, Arthur Marsh wrote:
>
> > ok, after applying the "second take" search.c patch, I get:
> >
> >   sh:grub> ls -l
> > Device hd0: Partition table
> >          Partition hd0,7: Filesystem type ext2, Last modification time 
> > 2009-07-07
> >   06:24:14 Tuesday, UUID 96c96a61-8615-4715-86d0-09cb8c62638c
> >          Partition hd0,6: Filesystem type fat, UUID 7417-5aff
> >          Partition hd0,5: Unknown filesystem
> >          Partition hd0,1: Filesystem type ext2, Last modification time 
> > 2009-07-07
> >   06:26:23 Tuesday, UUID bfdeb6d6-0b77-4beb-a63d-bdc3e455b8ea
>
> So it's something triggered by a condition in the real bootloader.
>
> > > > > sh:grub> search -l ""
> > > > > Segmentation fault
> > > > This should be fixed in Subversion.  My mistake.  Please test it.  The
> > > > patch for unifying search won't help solve this problem.
> > now I get:
> >
> > sh:grub> search -l ""
> >   hd0,7 hd0,1
> > sh:grub>
>
> Good.
>
> > > > > In real grub:
> > > > >
> > > > > ls -l
> > > > >
> > > > > hd0: Partition table
> > > > > Partition hd0,1: Filesystem cannot be accessed
> > > > > Device hd1: filesysetm cannot be accessed
> > > > > Device hd2: filesystem cannot be accessed
> > > > > Device fd0: Filesystem cannot be accessed
> > > > > error: no such disk
> > With the second-take patch I get the same result.
>
> It looks like there are several issues are at play here.  There is an
> issue with hd0,1, and then there is an issue with error handling.  I
> think we should deal with the error handling first, as it will stand in
> the way.
>
> > With real grub and the first and second-take patch I get:
> >
> > search -l ""
> >
> > hd1,5 hd1,3
>
> It looks like hd0 is ignored.

Yes.

I still get that with 'search -l ""' on real grub, but now (SVN 2402?) 
grub-emu shows:

sh:grub> search -l  ""
 hd0,7 hd0,1 hd3,5 hd3,3

sh:grub> ls
(host) (hd0) (hd0,7) (hd0,6) (hd0,5) (hd0,1) (hd1) (hd1,5) (hd1,1) (hd3) 
(hd3,7)
 (hd3,6) (hd3,5) (hd3,3) (hd3,1)
sh:grub>

By way of explanation, here is what is on the machine:

# fdisk -l

Disk /dev/hda: 320 GB, 320070320640 bytes
255 heads, 63 sectors/track, 38913 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes

   Device Boot      Start         End      Blocks   Id  System
/dev/hda1   *           1        1044     8385898   83  Linux
/dev/hda2            1045       38913   304174710    f  Extended LBA
/dev/hda7            1045       34462   268422052   83  Linux
Warning: Partition 7 does not end on cylinder boundary.
/dev/hda6           34463       38639    33543720   1b  Hidd FAT32
Warning: Partition 6 does not end on cylinder boundary.
/dev/hda5           38640       38913     2192872   82  Linux swap
Warning: Partition 5 does not end on cylinder boundary.
Warning: Unable to open /dev/hdb read-write (Read-only file system). 
/dev/hdb has been opened read-only.
Error: /dev/hdb: unrecognised disk label

Disk /dev/hdc: 40 GB, 40057113600 bytes
255 heads, 63 sectors/track, 4870 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes

   Device Boot      Start         End      Blocks   Id  System
/dev/hdc1   *           1        1785    14337981   1c  Hidd FAT32 LBA
/dev/hdc2            1786        4040    18105255    f  Extended LBA
/dev/hdc5            1786        3313    12265627   83  Linux
Warning: Partition 5 does not end on cylinder boundary.
/dev/hdc6            3314        3428      915705   82  Linux swap
Warning: Partition 6 does not end on cylinder boundary.
/dev/hdc7            3429        4040     4907857   1b  Hidd FAT32
Warning: Partition 7 does not end on cylinder boundary.
/dev/hdc3            4041        4870     6658942   83  Linux

Disk /dev/sda: 8 GB, 8134801920 bytes
255 heads, 63 sectors/track, 989 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes

   Device Boot      Start         End      Blocks   Id  System
/dev/sda1               1         990     7952143   83  Linux
Warning: Partition 1 does not end on cylinder boundary.

Disk /dev/sdb: 4 GB, 4334722560 bytes
255 heads, 63 sectors/track, 527 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes

   Device Boot      Start         End      Blocks   Id  System
/dev/sdb1   *           1         261     2096451    6  FAT16
/dev/sdb2             262         527     2128612    f  Extended LBA
/dev/sdb5             262         527     2128612    b  FAT32
Warning: Partition 5 does not end on cylinder boundary.
Error: /dev/md0: unrecognised disk label


Regards,

Arthur.