Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port))

[Pavel Roskin]

On Fri, 2009-06-26 at 19:03 +0200, Robert Millan wrote:

> 03-simple-symtab.patch looks nice, much cleaner than what I had.

Thanks!

> But as for 02-elf-renames.patch we could try to make this more consistent.  In
> efiemu I used 'W' (inspired by ElfW() macro in glibc), then in some places you
> use 'K' and in other places 'T'.  Can we use the same everywhere?  I don't
> care which letter, I'm not THAT much into bikeshed :-)

"T" stands for "target" and "K" stands for "kernel".  Yes, we can use
ElfW everywhere.  But I would try to avoid any mass renames.  It's very
easy to write Elf instead of ElfW somewhere in the code, and it would
compile, but it won't work.

Maybe we could have two headers, elf32.h and elf64.h, and every file
that needs Elf definitions would include one of them, dependent on which
elf format it wants.  Including both elf32.h and elf64.h from one source
should be impossible.  It could be a separate patch that would go in
before the ROM modules support.

-- 
Regards,
Pavel Roskin