|
From: | Christian Franke |
Subject: | Re: [2342] 2009-06-18 Vladimir Serbinenko <address@hidden> |
Date: | Sat, 20 Jun 2009 09:04:13 +0200 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090403 SeaMonkey/1.1.16 |
Pavel Roskin wrote:
On Fri, 2009-06-19 at 22:05 +0200, Christian Franke wrote:This was the AC_MSG_RESULT(...) for the AC_MSG_CHECKING([for option to link raw image]) which is still present for the "$grub_cv_apple_target_cc" != "yes" case.I would suggest to move the AC_MSG_CHECKING outside the 'if "$grub_cv_apple_target_cc" = "yes" ... fi' and re-add the AC_MSG_RESULT.Thanks for pointing it out. Actually, the message is not needed at all. There is no "checking" that needs to be communicated to the user. It would be appropriate if configure was running a compiler or looked for some tool in the PATH. In this case, it's just shell variable assignments with on test for a file.
I would prefer an output here even if the test done isn't a 'real' configure check. Would also make sense when we later apply your
'Use common linker script for all i386-pc systems' suggestion. But if you want to remove this messages it is also fine with me. Same would then possibly also apply to the AC_MSG_CHECKING([for command to convert module to ELF format]) a few lines below. -- Regards, Christian Franke
[Prev in Thread] | Current Thread | [Next in Thread] |