[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] Re: Grub needs to check the programming interface for us
From: |
Pavel Roskin |
Subject: |
Re: [PATCH 0/4] Re: Grub needs to check the programming interface for usb controllers |
Date: |
Mon, 08 Jun 2009 16:30:59 -0400 |
On Mon, 2009-06-08 at 18:45 +0100, address@hidden wrote:
> Here's a second try. I used quilt to manage the patch series but
> mailed them by hand instead of exporting to a mailbox, and didn't
> realise that they weren't named as *.patch (otherwise I think the
> content type would have been fine). I should probably move on to git,
> but I was a little intimidated by the idea of re-writing history -
> manipulating a patch series seemed more natural to me. But onwards and
> upwards.
STGit manipulates the patches. It was inspired by quilt. It should be
really easy to learn for someone who knows git.
> I've removed all changes to trailing whitespace, as requested. There
> is still a whitespace change in side a comment, something I noticed
> with syntax highlighting.
I've applied your patches. The third patch in the series introduced a
compile warning due to iobase being a pointer on OHCI. I fixed that.
Please note that the ChangeLog is wrapped at the column 72. All
non-empty lines except the author's name start with one tab. Please
specify thew functions affected by your changes unless the changes are
in the top-level code or all over the place.
--
Regards,
Pavel Roskin