[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support up to 256 SCSI disks on Linux
From: |
Robert Millan |
Subject: |
Re: [PATCH] Support up to 256 SCSI disks on Linux |
Date: |
Mon, 13 Apr 2009 15:59:39 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Apr 11, 2009 at 01:05:19AM +0200, phcoder wrote:
> Robert Millan wrote:
>> On Wed, Mar 04, 2009 at 10:16:29PM +0100, Robert Millan wrote:
>>>> else if (major == SCSI_DISK0_MAJOR)
>>>> - sprintf (name, "/dev/sd%c", 'a' + minor / 16);
>>>> + grub_util_getdiskname_scsi (name, 0, minor / 16);
>>>> + else if (major == SCSI_DISK1_MAJOR)
>>>> + grub_util_getdiskname_scsi (name, 1, minor / 16);
>>>> [...]
>>> Can this be factorized somehow? Space in raid.mod is quite critical; when
>>> used it usually ends up in core.img, which needs to fit in the embed area.
>>
>> Oh, I'm sorry. I thought you were editting disk/raid.c. util/raid.c has no
>> size issues. A macro would still be nice though.
>>
> What about making an array of SCSI_DISK?_MAJOR and then just go through it?
Sounds good.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."