grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.


From: phcoder
Subject: Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.
Date: Sat, 11 Apr 2009 21:10:26 +0200
User-agent: Thunderbird 2.0.0.21 (X11/20090318)

I do not agree with having separate grub_itoa/grub_ltoa/grub_lltoa in kernel where the size is critical. We should have only lltoa and use it in all contexts. I know because of divmod64 it's slower than ltoa or itoa but it's used only for output so speed isn't so important
David Miller wrote:
From: "Yoshinori K. Okuji" <address@hidden>
Date: Sat, 11 Apr 2009 19:19:49 +0900

On Saturday 11 April 2009 17:08:29 David Miller wrote:
The grub printf code tries to treat 'long' and 'int' the same,
that doesn't work on (most) 64-bit platforms.
Right. Good finding.

Committed.  Thanks for reviewing.


_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel


--

Regards
Vladimir 'phcoder' Serbinenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]