grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Split of normal mode (version 2)


From: Yoshinori K. Okuji
Subject: Re: [PATCH] Split of normal mode (version 2)
Date: Sun, 5 Apr 2009 23:33:02 +0900
User-agent: KMail/1.9.10

On Saturday 04 April 2009 14:06:18 Bean wrote:
> One of the problem for normal.mod dependency is its side effect. For
> example, currently ls.mod depend on normal.mod just for
> grub_normal_print_device_info. If we want to embed ls.mod in core.img,
> we must embedded normal.mod as well, along with a lot of
> initialization actions that we may not want.

Right, if we can completely merge the ls on rescue mode and that on normal 
mode. For now, I am not sure if this is feasible, so I prefer to keep a poor 
version of ls for rescue mode, which does not require functions in 
normal.mod, until you prove that that is feasible.

> We can generate a handler.lst by scanning source for
> grub_parser_register, etc, just like commands.lst:
>
> parser.sh: sh
> reader.normal: normal
> menu.textmenu: textmenu
> terminal_outout.gfxterm: gfxterm
>
> We can then read it in normal.mod and set the hooks for all handler
> classes.

I like if you can merge all kinds of handlers this way, thus eliminating the 
command.lst and the fs.lst.

But I still think that having commands for parsers and menus, since you can 
do:

grub> sh /boot/grub/foo.sh
grub> textmenu
grub> gfxmenu

They won't be very useful for most people, but could be useful for 
development.

Regards,
Okuji




reply via email to

[Prev in Thread] Current Thread [Next in Thread]