Re: Leak fixes

[phcoder]

committed
phcoder wrote:
> Robert Millan wrote:
> > On Sun, Mar 22, 2009 at 02:09:52PM +0100, phcoder wrote:
> > >    -  grub_disk_cache_invalidate (dev_id, disk_id, sector);
> > > -     index = grub_disk_cache_get_index (dev_id, disk_id, sector);
> > >    cache = grub_disk_cache_table + index;
> > > + +  cache->lock = 1;
> > > +  grub_free (cache->data);
> > > +  cache->data = 0;
> > > +  cache->lock = 0;
> >
> > Does this imply grub_disk_cache_invalidate() is not working properly?  
> > Can it
> > be fixed instead?
> No it works fine. But it's used to say to cache subsystem "block number 
> N on disk DISK" was updated. In this case when new block collides with 
> old one old one has to be freed even if it's still valid


--

Regards
Vladimir 'phcoder' Serbinenko