Re: [PATCH] Split of the normal mode

[Vesa Jääskeläinen]

Bean wrote:
> Hi,
> 
> This patch split the function of normal mode into small modules, here
> is a summary:
> 
> 1, Move dynamic command loader to commands/dyncmd.c (dyncmd.mod)
> 2, Move automatic fs loader to fs/autofs.c (autofs.mod)
> 3, Split normal mode into three major parts:
> parser/normal - normal mode parser (nparser.mod)
> reader/normal - normal mode command line reader (nreader.mod)
> menu/text - menu viewer (tmenu.mod)
> 4, Generic menu function move to menu/menu.c and menu/menu_viewer.c. 
> (menu.mod)
> 5, Misc function move to lib/misc.c lib/completion.c (misc.mod)
> 6, setjmp function move to lib/i386, lib/x86_64, lib/powerpc and
> lib/sparc64 (setjmp.mod)

Umh... I could somewhat agree with moving text menu out of normal.mod.
But...

I feel we have passed the over engineering milestone sometime ago... and
 I am not frankly happy about that...

Changes like this just make it a) harder to maintain, b) bigger overall
size impact, c) as a plus more modular approach...

I also fear that we seem to be missing some lead for the project that
could use his authority to make decisions...