grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ELF bugfixes


From: Robert Millan
Subject: Re: ELF bugfixes
Date: Wed, 18 Mar 2009 11:12:27 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Fri, Mar 13, 2009 at 09:52:39PM +0100, phcoder wrote:
> -  grub_multiboot_payload_entry_offset = ehdr->e_entry - 
> phdr(lowest_segment)->p_vaddr;
> +  for (i = 0; i < ehdr->e_phnum; i++)
> +    if (phdr(i)->p_vaddr <= ehdr->e_entry 
> +     && phdr(i)->p_vaddr + phdr(i)->p_memsz > ehdr->e_entry)
> +      grub_multiboot_payload_entry_offset = (ehdr->e_entry - 
> phdr(i)->p_vaddr)
> +     + (phdr(i)->p_paddr  - phdr(lowest_segment)->p_paddr);

You need to handle the case in which grub_multiboot_payload_entry_offset is left
uninitialized (it needs to be initialized each time the multiboot command is
run, not just when the module is loaded).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]