grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] new static const char[] channel (was: modname)


From: Robert Millan
Subject: Re: [PATCH] new static const char[] channel (was: modname)
Date: Mon, 1 Sep 2008 23:55:50 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Mon, Sep 01, 2008 at 01:24:16PM +0200, Felix Zielcke wrote:
> Am Samstag, den 30.08.2008, 14:42 +0200 schrieb Robert Millan:
> 
> > 
> > grub_dprintf itself refers to that as "condition".  I'd personally prefer
> > "channel" though.  What do others think?
> 
> I used now just channel, if others have better suggestions a
> s/channel/whatever shouldn't be too difficult.
> The only grub_dprintf calls that I haven't touched now are in
> fs/reiserfs.c
> It uses "reiserfs" and "reiserfs_tree", I wasn't sure if I should merge
> them or make a channel2="reiserfs_tree"

Or perhaps debug_channel, to make it less ambigous?

Looks fine to me, but please wait a bit to see if others have any opinion
on this.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]