grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] new static const char[] channel (was: modname)


From: Felix Zielcke
Subject: Re: [PATCH] new static const char[] channel (was: modname)
Date: Mon, 01 Sep 2008 13:24:16 +0200

Am Samstag, den 30.08.2008, 14:42 +0200 schrieb Robert Millan:

> 
> grub_dprintf itself refers to that as "condition".  I'd personally prefer
> "channel" though.  What do others think?

I used now just channel, if others have better suggestions a
s/channel/whatever shouldn't be too difficult.
The only grub_dprintf calls that I haven't touched now are in
fs/reiserfs.c
It uses "reiserfs" and "reiserfs_tree", I wasn't sure if I should merge
them or make a channel2="reiserfs_tree"

fz:/boot/grub# /bin/ls -l core.img
-rw-r--r-- 1 root root 25171 31. Aug 19:39 core.img
fz:/boot/grub# /bin/ls -l core.img
-rw-r--r-- 1 root root 25153  1. Sep 13:19 core.img

Phew that was it worth :)

-- 
Felix Zielcke

Attachment: channel.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]