Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE

[Carles Pina i Estany]

Hi,

I was just thinking now...

On Aug/24/2008, Carles Pina i Estany wrote:

>       * include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE):
>       Changed to 0x5100.
>       (GRUB_TERM_PPAGE): Changed to 0x4900.
> 
>       * include/grub/sparc64/ieee1275/console.h: Likewise.
> 
>       * include/grub/i386/pc/console.h: Likewise.
> 
>       * include/grub/efi/console.h: Likewise.

I was just thinking... is there any reason that we have the same macros
in 4 different files?

Why not having just a grub/console_scancodes.h: 

#ifndef GRUB_CONSOLE_SCAN_CODES

#define GRUB_CONSOLE_KEY_LEFT           0x4B00
#define GRUB_CONSOLE_KEY_RIGHT          0x4D00
#define GRUB_CONSOLE_KEY_UP             0x4800
#define GRUB_CONSOLE_KEY_DOWN           0x5000
#define GRUB_CONSOLE_KEY_IC             0x5200
#define GRUB_CONSOLE_KEY_DC             0x5300
#define GRUB_CONSOLE_KEY_BACKSPACE      0x0008
#define GRUB_CONSOLE_KEY_HOME           0x4700
#define GRUB_CONSOLE_KEY_END            0x4F00
#define GRUB_CONSOLE_KEY_NPAGE          0x5100
#define GRUB_CONSOLE_KEY_PPAGE          0x4900

#endif

and include this file from the other 4 files?

Thanks,

-- 
Carles Pina i Estany            GPG id: 0x17756391
        http://pinux.info