Re: [PATCH] Replace magic numbers by constants

[Carles Pina i Estany]

Hi,

On Aug/20/2008, Robert Millan wrote:
> On Sun, Aug 17, 2008 at 09:11:29PM +0200, Carles Pina i Estany wrote:
> > Ok:
> > 
> > --------
> > 2008-08-17  Carles Pina i Estany  <address@hidden>
> > 
> >         * menu/normal.c (run_menu): Replace hardcoded numbers with macros
> >     (16 for GRUB_TERM_UP and 14 for GRUB_TERM_DOWN)
> > --------
> 
> Thanks, I checked this in.
> 
> Btw, were you going to add support for PageUp / PageDown as well? :-)

Yes, that was my plan.

Today (probably) I will write a proposal of how would behave (how much
lines would scroll, which physical line number would be the new selected
-last one of the screen, first one-). When we agree (if we do :-) ) I
will write the patch (hopefully on weekend).

I will also start a new mailing thread.

-- 
Carles Pina i Estany            GPG id: 0x17756391
        http://pinux.info