grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Misc patches for grub2


From: Pavel Roskin
Subject: Re: [PATCH] Misc patches for grub2
Date: Sun, 27 Jul 2008 00:36:43 -0400

On Fri, 2008-07-25 at 14:58 -0400, Chris Knadle wrote:
> On Friday 25 July 2008, Bean wrote:
> > On Sat, Jul 26, 2008 at 1:19 AM, Chris Knadle <address@hidden> 
> wrote:
> > > On Friday 25 July 2008, Bean wrote:
> > >> 4. rename appleloader command to bootcamp
> > >>
> > >> The name appleloader may be a little confusing, bootcamp seems to be a
> > >> better choice.
> > >
> > >   Rather than patching all of the content from appleloader.c to
> > > bootcamp.c you may want to consider doing a 'git-mv' to rename the file
> > > instead.
> >
> > Yes, i do use git-mv to rename files, but when i use git-diff to
> > generate the patch, it looks like this.
> 
>    Oh...  Okay I think I understand why.  'git-diff -M' can detect the 
> renames 
> and just list them, but the 'patch' command can't use that to incorporate the 
> renames, which is probably why the -M behavior isn't the default.  
> 
>    So...  nevermind.  ;-)

Our main repository is in Subversion, so whoever applies the patch
should use "svn move" to keep the contiguous file history.  Unlike git,
which trusts the contents in the first place, Subversion is more
sensitive to whatever users are telling it.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]