Re: [PATCH] add a counter in grub_dprintf

[Isaac Dupree]

Robert Millan wrote:
> How about adding a counter to grub_dprintf to make it easy to instrument
> GRUB and find which are the bottlenecks in boot time?
>
> Sidenote: perhaps it'd be a good idea to conditionalize all grub_dprintf
> calls with #ifdef DEBUG to obtain a smaller core.img.  It's not hard to
> ask a user to rebuild if dprintf is needed,

Are the dprintf's useful for users' debugging, not just debugging GRUB 
bugs?  If it is, I'm not sure... If I accidentally broke something on my 
disk so that the core image couldn't find the modules/configuration, 
then it might be a little hard to rebuild grub and reinstall on that 
machine.  Obviously I'll be able to, somehow, if my computer isn't 
completely hosed, but I'd rather be able to search for debugging 
information I recorded ASAP so I need fewer iterations of nuisance for 
myself.  Perhaps a minor issue.

-Isaac