grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Handling command line option for core.img and g2ldr


From: Robert Millan
Subject: Re: [PATCH] Handling command line option for core.img and g2ldr
Date: Thu, 28 Feb 2008 11:18:21 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Mon, Feb 25, 2008 at 02:10:46AM -0500, Pavel Roskin wrote:
> Quoting Bean <address@hidden>:
> 
> >This patch allow passing command line options to core.img or g2ldr:
> 
> Isn't it an overkill?  When do you think it would be really needed in  
> practice?  I don't feel good about adding code just because we can.

I agree with Pavel.  Size is in init.c is very important.  The MBI structure
already contains the info for GRUB to figure out $prefix and $root, and other
variables can be set by user after GRUB has started.  So what is the purpose
of an additional interface?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]