grub-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio tra

From: Christian Franke
Subject: Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection
Date: Wed, 06 Feb 2008 18:42:18 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7 
Robert Millan wrote:

2008-02-05  Christian Franke  <address@hidden>

        * fs/cpio.c (grub_cpio_find_file): Return GRUB_ERR_NONE
        and (*ofs = 0) instead of GRUB_ERR_FILE_NOT_FOUND on last


I would suggest "(and set *ofs = 0)" here to make it clearer.



OK.

2008-02-06  Christian Franke  <address@hidden>

        * fs/cpio.c (grub_cpio_find_file): Return GRUB_ERR_NONE
        (and set *ofs = 0) instead of GRUB_ERR_FILE_NOT_FOUND on
        last block of a cpio or tar stream.
        Check for "TRAILER!!!" instead of any empty data
        block to detect last block of a cpio stream.
        (grub_cpio_dir): Fix constness of variable np.
        (grub_cpio_open): Return GRUB_ERR_FILE_NOT_FOUND if
        cpio or tar trailer is detected.  This fixes a crash
        on open of a non existing file.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]