grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grub-probe -t prefix, -t all


From: Christian Franke
Subject: Re: [PATCH] grub-probe -t prefix, -t all
Date: Sat, 10 Nov 2007 01:03:25 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4

Robert Millan wrote:
...
Note that make_system_path_relative_to_its_root() actually exists :-/


Sorry, I didn't search update-grub_lib.in :-\

Apparently both grub_get_prefix() and make_system_path_relative_to_its_root() use the same algorithm. Both do not work on Cygwin due to special (multi- to single-root) mount point handling.

It is desirable to have only one implementation for this non-trivial function. A native C implementation is needed for grub-setup, therefore "grub-probe -t prefix" makes sense for scripts.


If you provide an (obviously better) way to do the same thing, maybe you
could also get rid of the other one in your patch?


Yes.

Christian





reply via email to

[Prev in Thread] Current Thread [Next in Thread]