Re: grub2 ChangeLog term/i386/pc/serial.c

[Marco Gerards]

Robert Millan <address@hidden> writes:

> On Wed, Nov 07, 2007 at 10:35:17PM +0200, Vesa Jääskeläinen wrote:
>> > grub_inb() and grub_outb() are based on the inb()/outb() implementation
>> > from glibc headers, so I kept the same arguments for consistency.
>> 
>> I see... Once again inconsistency introduced by Unix folks... as AT&T
>> assembler wouldn't be enough, they then poisons C libs too... oh well...
>> another thing to try to keep in mind...
>
> I always thought the Right Way to do this would be implement it in GCC,
> so that you can do things like:
>
>   __some_magic__(PORT_ADDR) |= 0x80;
>
> which is much more beatufil than either of:
>
>   outb (PORT_ADDR, inb (PORT_ADDR) | 0x80);
>
>   outb (inb (PORT_ADDR) | 0x80, PORT_ADDR);
>
> don't you think?
>
> (now if someone is bored and takes my suggestion to gcc-patches, that'd make
> my day...)

That's possible in C++ using operator overloading AFAIK.

Did this commit fix serial support for LB?

--
Marco