grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] do not require that device is a partition


From: Marco Gerards
Subject: Re: [PATCH] do not require that device is a partition
Date: Mon, 15 Oct 2007 09:59:19 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Robert Millan <address@hidden> writes:

> New patch after IRC discussion with Marco.  code + ChangeLog should be
> self-explanatory.
>
> -- 
> Robert Millan
>
> <GPLv2> I know my rights; I want my phone call!
> <DRM> What use is a phone call, if you are unable to speak?
> (as seen on /.)
>
> 2007-10-14  Robert Millan  <address@hidden>
>
>       * normal/misc.c (grub_normal_print_device_info): Do not probe for
>       filesystem when dev->disk is unset.
>       Do probe for filesystem even when dev->disk->has_partitions is set.
>       In case a filesystem is found, always report it.
>       In case it isn't, if dev->disk->has_partitions is set, report that
>       a partition table was found instead of reporting that no filesystem
>       could be identified.


"Do not probe for filesystem when dev->disk is unset."

This was already the case, right?  So perhaps this line should be removed?

Feel free to commit it.

--
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]