grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for boot message


From: Mischa Spiegelmock
Subject: Re: Patch for boot message
Date: Sun, 12 Aug 2007 11:47:24 -0700
User-agent: Thunderbird 2.0.0.6 (Windows/20070728)

Robert Millan wrote:
On Fri, Aug 10, 2007 at 11:18:55PM -0700, Mischa Spiegelmock wrote:
I got sick of grub saying "The highlighted entry will be booted automatically in 1 seconds."

Here's a patch:

Index: normal/menu.c
===================================================================
RCS file: /sources/grub/grub2/normal/menu.c,v
retrieving revision 1.18
diff -r1.18 menu.c
331,332c331,332
<    The highlighted entry will be booted automatically in %d seconds.    ",
<                      timeout);
---
The highlighted entry will be booted automatically in %d
second%c     ",
                     timeout, (timeout == 1 ? ' ' : 's'));

This breaks l10n, and also adds a bogus ' ' (although that's a minor issue).

The SI symbol for second is 's'.  Why not using that instead?

Well whatever, I was just trying to fix the currently broken behavior. As for adding the "bogus" ' ', that's keeping in line with the comment on the line before:

         /* NOTE: Do not remove the trailing space characters.
            They are required to clear the line.  */

I just tried to do the least invasive patch that would keep the amount of characters constant.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]