grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Completion for arguments


From: Marco Gerards
Subject: Re: Completion for arguments
Date: Mon, 29 Aug 2005 17:27:34 +0200
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)

"Yoshinori K. Okuji" <address@hidden> writes:

> On Saturday 27 August 2005 00:11, Marco Gerards wrote:
>> +  /* Add the short arguments.  */
>> +  for (option = cmd->options; option->doc; option++)
>> +    {
>> +      if (!option->shortarg)
>> +    continue;
>
> This should be:
>
>   if (! grub_isgraph (option->shortarg))
>     continue;
>
> because we sometimes want to specify non-graph short arguments for 
> convenience.

You are right, I will fix this next time when I commit a patch.

Thanks,
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]