groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [groff] hyphenation issues


From: G. Branden Robinson
Subject: Re: [groff] hyphenation issues
Date: Sat, 5 May 2018 17:17:00 -0400
User-agent: NeoMutt/20170113 (1.7.2)

At 2018-05-05T15:43:35+0200, Werner LEMBERG wrote:
> 
> >> > +  static int n_max = (HYPHEN_NOT_LAST_LINE | HYPHEN_NOT_LAST_CHARS
> >> > +    | HYPHEN_NOT_FIRST_CHARS | HYPHEN_LAST_CHAR
> >> > +    | HYPHEN_FIRST_CHAR);
> >> 
> >> s/static int/int const/?
> 
> Please use `const int' – there is no single instance of `int const' in
> the groff code.

Okay.  The Global Groff Const Relocation can wait for some point in the
indefinite future.  ;-)

> I prefer that.  It's always a bit problematic ORing enumeration values
> (I know how to circumvent that limitation, but...)

That's fair.  I'll cook up a revised patch for review.

-- 
Regards,
Branden

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]