[Groff-commit] groff ChangeLog src/preproc/html/pushback.cpp

[Werner LEMBERG]

CVSROOT:        /cvsroot/groff
Module name:    groff
Changes by:     Werner LEMBERG <wl>     13/02/02 19:05:09

Modified files:
        .              : ChangeLog 
        src/preproc/html: pushback.cpp 

Log message:
        [grohtml] Don't ignore return value of `dup'.
        
        * src/preproc/html/pushback.cpp (pushBackBuffer::pushBackBuffer,
        pushBackBuffer::~pushBackBuffer): Abort if `dup' fails.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/groff/ChangeLog?cvsroot=groff&r1=1.1385&r2=1.1386
http://cvs.savannah.gnu.org/viewcvs/groff/src/preproc/html/pushback.cpp?cvsroot=groff&r1=1.8&r2=1.9

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/groff/groff/ChangeLog,v
retrieving revision 1.1385
retrieving revision 1.1386
diff -u -b -r1.1385 -r1.1386
--- ChangeLog   30 Jan 2013 04:03:29 -0000      1.1385
+++ ChangeLog   2 Feb 2013 19:05:09 -0000       1.1386
@@ -1,3 +1,10 @@
+2013-02-02  Gilles Espinasse  <address@hidden>
+
+       [grohtml] Don't ignore return value of `dup'.
+
+       * src/preproc/html/pushback.cpp (pushBackBuffer::pushBackBuffer,
+       pushBackBuffer::~pushBackBuffer): Abort if `dup' fails.
+
 2013-01-30  Bernd Warken  <address@hidden>
 
        * tmac/groff_man.man: Fix wrong connection for tbl(1).

Index: src/preproc/html/pushback.cpp
===================================================================
RCS file: /cvsroot/groff/groff/src/preproc/html/pushback.cpp,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -b -r1.8 -r1.9
--- src/preproc/html/pushback.cpp       5 Jan 2009 20:11:08 -0000       1.8
+++ src/preproc/html/pushback.cpp       2 Feb 2013 19:05:09 -0000       1.9
@@ -71,6 +71,9 @@
   lineNo   = 1;
   if (strcmp(filename, "") != 0) {
     stdIn = dup(0);
+    if (stdIn<0) {
+      sys_fatal("dup stdin");
+    }
     close(0);
     if (open(filename, O_RDONLY) != 0) {
       sys_fatal("when trying to open file");
@@ -87,7 +90,9 @@
   }
   close(0);
   /* restore stdin in file descriptor 0 */
-  dup(stdIn);
+  if (dup(stdIn)<0) {
+    sys_fatal("restore stdin");
+  }
   close(stdIn);
 }