Re: [Grep-devel] avoid new "syntax-check" failure

[Eric Blake]

On 12/30/2016 11:04 AM, Jim Meyering wrote:

> At least this one was doable. I've eliminated that hard-coded list
> with the attached:

> 
> +# Extract the raw list of symbol names with this:
> +gl_extract_define_simple = \
> +  /^\# *define ([A-Z]\w+)\(/ and print $$1
> +# Filter out duplicates and convert to a space-separated list:
> +_intprops_names := \
> +  $(shell f=$(gnulib_dir)/lib/intprops.h;                            \

Trying this out with m4, I get:

$ make
Can't open /lib/intprops.h: No such file or directory.
make  all-recursive
...

All other uses of $(gnulib_dir) prior to its ?= definition later in the
file are probably okay (because they are not actually expanded until
after the default definition has been parsed), but this particular
$(shell) usage does the wrong thing (since $(shell) is executed
immediately upon parse).  You probably need to hoist the definition of
$(gnulib_dir) up earlier in the file.

Testing a patch now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature