Re: [gpsd-users] Create an SVG skyview image from JSON data

[Gary E. Miller]

Yo Niccolo!

On Tue, 2 Oct 2018 11:28:25 +0200
Niccolo Rigacci <address@hidden> wrote:

> I installed gpsd and gpsd-clients packages on my Raspberry Pi 
> (version 3.16-4, Raspbian Stretch distro).

Cool.

> I was wondering if there is a tool to draw a nice skyview image 
> to be shown via a web interface.

Just the 2 you found.

> So I wrote a simple Python script which reads the JSON data of a 
> "SKY" response, then it produces the SVG file. I made it as much 
> as parametric as possible, to customize layout and colors.

I have trouble with your sample output, I could not get it to
render.  Sample failure

    # display skyview.svg 
    Intrinsic has incorrect return type!
    i8 addrspace(2)* ()* @llvm.amdgcn.dispatch.ptr
    LLVM ERROR: Broken function found, compilation aborted!

I consider this a blocker.  Probably easy to fix?

> Can this script be of some interest to someone? Should I 
> contribute it somewhere?

You sent it to the right place.  Not quite ready, but close.

All gpsd code passes pycodestyle (PEP8 checks), but yours has
68 issues:

     # pycodestyle skyview2svg  | wc -l
    68

We place less importance on pylint, but it does often find bugs.  In
your case there is a lot to fix.

Your code only runs on Python 2, which is EOL in 2020.  All gpsd code
runs on both Python 2 and Python 3.

We can help you with the pycodestyle, pylint and Python 2/3, you'll need
to figure out the SVG error.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

pgpKzrkt77n7n.pgp
Description: OpenPGP digital signature