gpsd-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-users] Control socket read bug?


From: Tomalak Geret'kal
Subject: [gpsd-users] Control socket read bug?
Date: Wed, 04 Apr 2012 17:52:36 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1

Hi

gpsd 3.2 gpsd/gpsd.c around line 2205:

        char buf[BUFSIZ];

        while (read(cfd, buf, sizeof(buf) - 1) > 0) {
gpsd_report(LOG_IO, "<= control(%d): %s\n", cfd, buf);
            handle_control(cfd, buf);
        }

`read` doesn't null-terminate, so is there a bug here? I'm seeing my device addition commands accumulate spurious noise after them.

Around 2295 in the current git HEAD seems to have the same problem (http://git.savannah.gnu.org/cgit/gpsd.git/tree/gpsd.c#n2295).

Cheers

Tom



reply via email to

[Prev in Thread] Current Thread [Next in Thread]