Re: opencdk under LGPL

[Simon Josefsson]

Simon Josefsson <address@hidden> writes:

> Can't we revert the gnutls_openpgp_privkey_sign_hash change, and
> introduce a new gnutls_openpgp_privkey_sign_hash2 instead?  That will
> avoid breaking the ABI again for the 2.4 release, which I think would be
> a good thing.

There seems to be another ABI diff between 2.2 and 2.3.x:

   int gnutls_openpgp_keyring_check_id (gnutls_openpgp_keyring_t ring,
-                                      const unsigned char keyid[8],
+                                      gnutls_openpgp_keyid_t keyid,
                                       unsigned int flags);

Maybe there are more, it seems the gnutls_openpgp_keyid_t change isn't
backwards compatible:

make[4]: Entering directory `/home/jas/src/gnutls/guile/src'
/bin/sh ../../libtool --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H 
-I. -I../..  -I../../includes -I../../includes -I../.. -I.  -g -Wall 
-Wcast-align -W -Wpointer-arith -Wchar-subscripts -Wformat-security 
-Wno-format-y2k -Wmissing-braces -Winline -Wstrict-prototypes 
-Wno-unused-parameter -pipe  -Wno-strict-prototypes -I../../lgl -I../../lgl  -g 
-O2 -Wno-pointer-sign -MT libguile_gnutls_extra_v_1_la-extra.lo -MD -MP -MF 
.deps/libguile_gnutls_extra_v_1_la-extra.Tpo -c -o 
libguile_gnutls_extra_v_1_la-extra.lo `test -f 'extra.c' || echo './'`extra.c
 gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../includes -I../../includes 
-I../.. -I. -g -Wall -Wcast-align -W -Wpointer-arith -Wchar-subscripts 
-Wformat-security -Wno-format-y2k -Wmissing-braces -Winline -Wstrict-prototypes 
-Wno-unused-parameter -pipe -Wno-strict-prototypes -I../../lgl -I../../lgl -g 
-O2 -Wno-pointer-sign -MT libguile_gnutls_extra_v_1_la-extra.lo -MD -MP -MF 
.deps/libguile_gnutls_extra_v_1_la-extra.Tpo -c extra.c  -fPIC -DPIC -o 
.libs/libguile_gnutls_extra_v_1_la-extra.o
In file included from extra.c:27:
../../includes/gnutls/openpgp.h:62: error: expected declaration specifiers or 
'...' before 'gnutls_certificate_print_formats_t'
extra.c: In function 'scm_gnutls_openpgp_certificate_id':
extra.c:169: warning: passing argument 2 of 'gnutls_openpgp_crt_get_key_id' 
from incompatible pointer type
extra.c: In function 'scm_gnutls_openpgp_certificate_id_x':
extra.c:201: warning: passing argument 2 of 'gnutls_openpgp_crt_get_key_id' 
from incompatible pointer type
extra.c: In function 'scm_gnutls_openpgp_keyring_contains_key_id_p':
extra.c:494: error: incompatible type for argument 2 of 
'gnutls_openpgp_keyring_check_id'
make[4]: *** [libguile_gnutls_extra_v_1_la-extra.lo] Error 1

/Simon