Re: Theme issues with current svn

[Germán Arias]

Thanks Fred.

Germán

El sáb, 24-10-2015 a las 23:11 +0200, Fred Kiefer escribió:
> Am 24.10.2015 um 20:29 schrieb Germán A. Arias:
> > El sáb, 24-10-2015 a las 09:21 +0200, Fred Kiefer escribió:
> >> I still don't understand what is happening here. Could you please provide 
> >> me with an example file? Are all Silver theme files affected or just a few?
> >> There are two changes I made there. One to speed up premultiply and the 
> >> other to generate multiple tiff images in one file. 
> >>
> >> Fred
> >>
> > Attached one of the problematic file. The images at directory
> > "ThemeImages" works fine, only the images at directory "ThemeTiles" are
> > affected. Except the image "MenuItem.tiff" which is loaded directly in
> > the theme code to draw the menu items, this works fine.
> > 
> > Is like if the images at "ThemeTiles" are treated different than other
> > images. So maybe the problem is not directly in your changes, but in how
> > GSThemeDrawing handle the tiles.
> > 
> > Germán
> 
> Thank you very much for the details, this helped to track down the
> issue. Interestingly it was the second change that triggered the
> problem. When loading theme tiles from a single image the code relies on
> the method TIFFRepresentation to create a new bitmap image
> representation as a side effect. With my change I had accidentally
> broken this behaviour as now TIFFRepresentationOfImageRepsInArray: on
> NSBitmapImageRep would always return a (potentially empty) NSData
> object. I changed this back to the old behaviour and now the theme works
> again.
> 
> Fred
>