Re: [Gnustep-cvs] r29139 - in /libs/gui/trunk: ChangeLog Source/NSSliderCell.m

[Fred Kiefer]

The change to setMinValue: and setMaxValue: surely are correct and the
addition of setObjectValue: is just great. What I don't understand is
why the method setDoubleValue:,  setFloatValue: and setIntValue: had to
be implemented. The default behaviour (calling setObjectValue:) should
just do the right thing.
Sadly this is not true for setStringValue:, where the current GNUstep
implementation on NSCell has a short cut which doesn't call
setObjectValue:. This should be corrected instead of having a separate
implementation here.

What should be the default value for isContinuous when the cell is just
created? When we get that right we may not have to set that value when
dearchiving, as it will get archived as action mask by the super class.

As for the commit access a simple mail to Adam should be sufficient to
get that. A line in a commit comment wont help. Who is supposed to read
that?


David Chisnall schrieb:
> Author: theraven
> Date: Sat Dec 19 01:05:52 2009
> New Revision: 29139
> 
> URL: http://svn.gna.org/viewcvs/gnustep?rev=29139&view=rev
> Log:
> * Source/NSSliderCell.m:
> Rework the handling of maxValue and minValue. The cell's value is now
> clamped to the permisible range when it is set, rather than in
> floatValue, matching OS X behaviour. setMinValue: and setMaxValue:
> also clamp the current value.
> Also make NSSliderCell continuous by default when unarchived (matches
> OS X).
> 
> Patch by Eric Wasylishen!
> (Please someone give him commit access)
> 
> 
> Modified:
>     libs/gui/trunk/ChangeLog
>     libs/gui/trunk/Source/NSSliderCell.m