[GNUnet-SVN] [libfints] branch master updated: Minor changes..

[gnunet]

This is an automated email from the git hooks/post-receive script.

marcello pushed a commit to branch master
in repository libfints.

The following commit(s) were added to refs/heads/master by this push:
     new 058b001  Minor changes..
058b001 is described below

commit 058b001f5d6ae09d88b018e974f66bc6c9a19a9a
Author: Marcello Stanisci <address@hidden>
AuthorDate: Mon Oct 8 16:23:19 2018 +0200

    Minor changes..
---
 src/libebics.c    | 25 +++++++++++++++----------
 src/libebics.h    |  9 +++------
 src/xmlmessages.c | 12 +++++++++---
 3 files changed, 27 insertions(+), 19 deletions(-)

diff --git a/src/libebics.c b/src/libebics.c
index 7f32acc..a617fb6 100644
--- a/src/libebics.c
+++ b/src/libebics.c
@@ -29,9 +29,6 @@
 #define LOG(level,...) EBICS_util_log_from (__LINE__,__FILE__,__func__,level, 
"libebics",__VA_ARGS__)
 
 
-
-
-
 static void
 gnutlslog (int level, const char *msg)
 {
@@ -398,16 +395,24 @@ EBICS_close_library ()
 }
 
 
+
+/**
+ * Customize a bunch of standard values in the tree (including
+ * the HostID).
+ */
 int
 EBICS_generate_message_ini (struct EBICS_genex_document *document,
                             struct EBICS_ARGS_build_header *headerArgs,
                             struct EBICS_ARGS_build_content_ini *iniArgs)
 {
 
-  struct EBICS_MSG_Spec foo[] = {
+  struct EBICS_MSG_Spec spec[] = {
+    /* Notably, it sets the HostID in the request document.  */
     EBICS_MSG_op_subcommand(EBICS_build_header_ebicsUnsecuredRequest,
                             headerArgs,
                             NULL),
+
+    /* Set a bunch of nodes (mostly strings) taking values from 'iniArgs'.  */
     EBICS_MSG_op_subcommand(EBICS_build_content_ini,
                             iniArgs,
                             iniArgs->document),
@@ -415,7 +420,7 @@ EBICS_generate_message_ini (struct EBICS_genex_document 
*document,
     EBICS_MSG_op_end()
   };
 
-  EBICS_MSG_parse_spec(foo, document);
+  EBICS_MSG_parse_spec(spec, document);
 }
 
 int
@@ -424,7 +429,7 @@ EBICS_generate_message_hia (struct EBICS_genex_document 
*document,
                             struct EBICS_ARGS_build_content_hia *hiaArgs)
 {
 
-  struct EBICS_MSG_Spec foo[] = {
+  struct EBICS_MSG_Spec spec[] = {
     EBICS_MSG_op_subcommand(EBICS_build_header_ebicsUnsecuredRequest,
                             headerArgs,
                             NULL),
@@ -436,7 +441,7 @@ EBICS_generate_message_hia (struct EBICS_genex_document 
*document,
   };
 
 
-  EBICS_MSG_parse_spec(foo, document);
+  EBICS_MSG_parse_spec(spec, document);
 }
 
 int
@@ -460,9 +465,9 @@ EBICS_generate_message_hpb (struct EBICS_genex_document 
*document,
 
 int
 EBICS_generate_message_camt053 (struct EBICS_genex_document *document, 
-                            struct EBICS_ARGS_build_header *headerArgs,
-                            struct EBICS_ARGS_build_auth *authArgs,
-                            struct EBICS_ARGS_build_content_camt053 
*camt053Args)
+                                struct EBICS_ARGS_build_header *headerArgs,
+                                struct EBICS_ARGS_build_auth *authArgs,
+                                struct EBICS_ARGS_build_content_camt053 
*camt053Args)
 {
   struct EBICS_MSG_Spec foo[] = {
     EBICS_MSG_op_subcommand(EBICS_build_header_ebicsRequest, headerArgs,NULL),
diff --git a/src/libebics.h b/src/libebics.h
index da17d72..c37461e 100644
--- a/src/libebics.h
+++ b/src/libebics.h
@@ -71,10 +71,7 @@ EBICS_generate_message_hpb (struct EBICS_genex_document 
*document,
 
 int
 EBICS_generate_message_camt053 (struct EBICS_genex_document *document, 
-                            struct EBICS_ARGS_build_header *headerArgs,
-                            struct EBICS_ARGS_build_auth *authArgs,
-                            struct EBICS_ARGS_build_content_camt053 
*camt053Args);
-
-
-
+                                struct EBICS_ARGS_build_header *headerArgs,
+                                struct EBICS_ARGS_build_auth *authArgs,
+                                struct EBICS_ARGS_build_content_camt053 
*camt053Args);
 #endif
diff --git a/src/xmlmessages.c b/src/xmlmessages.c
index 9ea54cd..c9c83fd 100644
--- a/src/xmlmessages.c
+++ b/src/xmlmessages.c
@@ -139,6 +139,11 @@ EBICS_build_header_ebicsRequest (void *cls, struct 
EBICS_genex_document *documen
   EBICS_MSG_parse_spec(header, document);
 }
 
+
+/**
+ * Among the most important things, this function
+ * causes the HostID value to be set in the document.
+ */
 void
 EBICS_build_header_ebicsUnsecuredRequest (void *cls,
                                           struct EBICS_genex_document 
*document)
@@ -167,9 +172,10 @@ EBICS_build_header_ebicsNoPubKeyDigestsRequest (void *cls, 
struct EBICS_genex_do
 }
 
 void
-EBICS_build_content_ini (void *cls, struct EBICS_genex_document *document)
+EBICS_build_content_ini (void *cls,
+                         struct EBICS_genex_document *document)
 {
-  struct EBICS_ARGS_build_content_ini *data = (struct 
EBICS_ARGS_build_content_ini*)cls;
+  struct EBICS_ARGS_build_content_ini *data = (struct 
EBICS_ARGS_build_content_ini*) cls;
   int retv;
 
   /* RSAKeyValue content */
@@ -184,7 +190,7 @@ EBICS_build_content_ini (void *cls, struct 
EBICS_genex_document *document)
     EBICS_MSG_op_del_node("//ds:X509Data"),
     EBICS_MSG_op_set_string("//esig:SignatureVersion","A005"),
     EBICS_MSG_op_set_string("//esig:PubKeyValue//ds:Modulus", modulus),
-    EBICS_MSG_op_set_string("//esig:PubKeyValue//ds:Exponent",exponent),
+    EBICS_MSG_op_set_string("//esig:PubKeyValue//ds:Exponent", exponent),
     EBICS_MSG_op_set_string("//esig:TimeStamp", tools_get_timestamp(date)),
     EBICS_MSG_op_set_string("//esig:PartnerID", data->partnerID),
     EBICS_MSG_op_set_string("//esig:UserID", data->userID),

-- 
To stop receiving notification emails like this one, please contact
address@hidden