[GNUnet-SVN] [taler-exchange] branch master updated (ba711d7 -> 1f02fc8)

[gnunet]

This is an automated email from the git hooks/post-receive script.

marcello pushed a change to branch master
in repository exchange.

    from ba711d7  polish refresh CMD
     new 566ad4f  polish track CMD
     new 1f02fc8  polish test helpers

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/exchange-lib/testing_api_cmd_track.c | 12 ------------
 src/exchange-lib/testing_api_helpers.c   |  5 ++++-
 src/exchange-lib/testing_api_loop.c      |  4 +++-
 3 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/src/exchange-lib/testing_api_cmd_track.c 
b/src/exchange-lib/testing_api_cmd_track.c
index 789b30b..60f412c 100644
--- a/src/exchange-lib/testing_api_cmd_track.c
+++ b/src/exchange-lib/testing_api_cmd_track.c
@@ -520,7 +520,6 @@ track_transfer_cb
   struct TALER_TESTING_Interpreter *is = tts->is;
   struct TALER_TESTING_Command *cmd = &is->commands[is->ip];
 
-  const struct TALER_TESTING_Command *wtid_cmd;
   struct TALER_Amount expected_amount;
 
   tts->tth = NULL;
@@ -588,17 +587,6 @@ track_transfer_cb
       return;
     }
 
-    /* FIXME: this block does nothing.  Remove?  */
-    wtid_cmd = TALER_TESTING_interpreter_lookup_command
-      (is, tts->wtid_reference);
-
-    if (NULL == wtid_cmd)
-    {
-      GNUNET_break (0);
-      TALER_TESTING_interpreter_fail (is);
-      return;
-    }
-
     /**
      * Optionally checking: (1) wire-details for this transfer
      * match the ones from a referenced "deposit" operation -
diff --git a/src/exchange-lib/testing_api_helpers.c 
b/src/exchange-lib/testing_api_helpers.c
index b3e32fc..749e5d8 100644
--- a/src/exchange-lib/testing_api_helpers.c
+++ b/src/exchange-lib/testing_api_helpers.c
@@ -346,7 +346,9 @@ TALER_TESTING_find_pk (const struct TALER_EXCHANGE_Keys 
*keys,
  * @param main_cb_cls closure for @a main_cb, typically NULL.
  * @param config_file configuration file for the test-suite.
  *
- * @return FIXME: depends on what TALER_TESTING_setup returns.
+ * @return GNUNET_OK if all is okay, != GNUNET_OK otherwise.
+ *         non-GNUNET_OK codes are GNUNET_SYSERR most of the
+ *         times.
  */
 int
 TALER_TESTING_setup_with_exchange (TALER_TESTING_Main main_cb,
@@ -457,6 +459,7 @@ TALER_TESTING_setup_with_exchange (TALER_TESTING_Main 
main_cb,
     }
   while (0 != system (wget_cmd));
 
+  /* NOTE: this blocks.  */
   result = TALER_TESTING_setup (main_cb,
                                 main_cb_cls,
                                 config_filename,
diff --git a/src/exchange-lib/testing_api_loop.c 
b/src/exchange-lib/testing_api_loop.c
index ac68859..e9197da 100644
--- a/src/exchange-lib/testing_api_loop.c
+++ b/src/exchange-lib/testing_api_loop.c
@@ -634,7 +634,9 @@ main_wrapper_exchange_connect (void *cls)
  *        key state.. if NULL, the interpreter will run without
  *        trying to connect to the exchange first.
  *
- * @return FIXME: not sure what 'is.result' is at this stage.
+ * @return GNUNET_OK if all is okay, != GNUNET_OK otherwise.
+ *         non-GNUNET_OK codes are GNUNET_SYSERR most of the
+ *         times.
  */
 int
 TALER_TESTING_setup (TALER_TESTING_Main main_cb,

-- 
To stop receiving notification emails like this one, please contact
address@hidden