[GNUnet-SVN] [gnurl] 111/173: schannel: Remove incorrect SNI disabled message

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to annotated tag gnurl-7.53.1
in repository gnurl.

commit 18495ecaccf936a9d7d6c96c08c644ceda83bd00
Author: JDepooter <address@hidden>
AuthorDate: Thu Feb 2 13:40:16 2017 -0800

    schannel: Remove incorrect SNI disabled message
    
    - Remove the SNI disabled when host verification disabled message
      since that is incorrect.
    
    - Show a message for legacy versions of Windows <= XP that connections
      may fail since those versions of WinSSL lack SNI, algorithms, etc.
    
    Bug: https://github.com/curl/curl/pull/1240
---
 lib/vtls/schannel.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/vtls/schannel.c b/lib/vtls/schannel.c
index ca7545662..bd9239956 100644
--- a/lib/vtls/schannel.c
+++ b/lib/vtls/schannel.c
@@ -130,6 +130,14 @@ schannel_connect_step1(struct connectdata *conn, int 
sockindex)
   infof(data, "schannel: SSL/TLS connection with %s port %hu (step 1/3)\n",
         hostname, conn->remote_port);
 
+  if(Curl_verify_windows_version(5, 1, PLATFORM_WINNT,
+                                 VERSION_LESS_THAN_EQUAL)) {
+     /* SChannel in Windows XP (OS version 5.1) uses legacy handshakes and
+        algorithms that may not be supported by all servers. */
+     infof(data, "schannel: WinSSL version is old and may not be able to "
+           "connect to some servers due to lack of SNI, algorithms, etc.\n");
+  }
+
 #ifdef HAS_ALPN
   /* ALPN is only supported on Windows 8.1 / Server 2012 R2 and above.
      Also it doesn't seem to be supported for Wine, see curl bug #983. */
@@ -197,7 +205,7 @@ schannel_connect_step1(struct connectdata *conn, int 
sockindex)
       schannel_cred.dwFlags |= SCH_CRED_NO_SERVERNAME_CHECK;
       infof(data, "schannel: verifyhost setting prevents Schannel from "
             "comparing the supplied target name with the subject "
-            "names in server certificates. Also disables SNI.\n");
+            "names in server certificates.\n");
     }
 
     switch(conn->ssl_config.version) {

-- 
To stop receiving notification emails like this one, please contact
address@hidden