[GNUnet-SVN] [gnunet] branch master updated: add hints on how to fix the multipeer tests

[gnunet]

This is an automated email from the git hooks/post-receive script.

lurchi pushed a commit to branch master
in repository gnunet.

The following commit(s) were added to refs/heads/master by this push:
     new a2b98912a add hints on how to fix the multipeer tests
a2b98912a is described below

commit a2b98912a9e67a450caa7493162c2af69a6d1e18
Author: lurchi <address@hidden>
AuthorDate: Thu Jan 26 01:13:46 2017 +0100

    add hints on how to fix the multipeer tests
---
 src/multicast/test_multicast_multipeer.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src/multicast/test_multicast_multipeer.c 
b/src/multicast/test_multicast_multipeer.c
index 792b49c49..e81b63f92 100644
--- a/src/multicast/test_multicast_multipeer.c
+++ b/src/multicast/test_multicast_multipeer.c
@@ -240,6 +240,8 @@ multicast_ca1 (void *cls,
   GNUNET_CRYPTO_ecdsa_key_get_public (member_key, &member_pub_key);
   
   // Get GNUnet identity of origin
+  // FIXME: the return value is not a GNUNET_PeerIdentity, it can retrieved in
+  // pi_cb: pinfo->result.id
   peer_id_origin = GNUNET_TESTBED_peer_get_information (peers[0],
                                                 GNUNET_TESTBED_PIT_IDENTITY,
                                                 pi_cb,
@@ -370,6 +372,16 @@ testbed_master (void *cls,
               
   peers = p;
 
+  /**
+   * FIXME:
+   * we can't already GNUNET_TESTBED_service_connect here, because in the 
+   * continuation callback multicast_ca1 we need the origin's peer identity
+   * which we can retrieve only using the asynchronous
+   * GNUNET_TESTBED_peer_get_information function.
+   * So we need to call GNUNET_TESTBED_peer_get_information here, and call
+   * GNUNET_TESTBED_service_connect in the result callback.
+   */
+
   /* connect to a peers service */
   op0 = GNUNET_TESTBED_service_connect
       (NULL,                    /* Closure for operation */

-- 
To stop receiving notification emails like this one, please contact
address@hidden