[GNUnet-SVN] r31109 - gnunet/src/scalarproduct

[gnunet]

Author: grothoff
Date: 2013-12-05 22:56:03 +0100 (Thu, 05 Dec 2013)
New Revision: 31109

Modified:
   gnunet/src/scalarproduct/gnunet-service-scalarproduct.c
Log:
use 'svalue' that is actually a signed integer, as otherwise cmp with 0 is 
always false

Modified: gnunet/src/scalarproduct/gnunet-service-scalarproduct.c
===================================================================
--- gnunet/src/scalarproduct/gnunet-service-scalarproduct.c     2013-12-05 
21:54:21 UTC (rev 31108)
+++ gnunet/src/scalarproduct/gnunet-service-scalarproduct.c     2013-12-05 
21:56:03 UTC (rev 31109)
@@ -1287,16 +1287,19 @@
 
   // generate r, p and q
   rand = initialize_mpi_vector (count);
-  for (i = 0; i < count; i++) {
-    value = (int32_t) GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK, 
UINT32_MAX);
+  for (i = 0; i < count; i++)
+  {
+    int32_t svalue;
 
+    svalue = (int32_t) GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_WEAK, 
UINT32_MAX);
+
     // long to gcry_mpi_t
-    if (value < 0)
+    if (svalue < 0)
       gcry_mpi_sub_ui (rand[i],
                        rand[i],
-                       -value);
+                       -svalue);
     else
-      rand[i] = gcry_mpi_set_ui (rand[i], value);
+      rand[i] = gcry_mpi_set_ui (rand[i], svalue);
   }
   p = GNUNET_CRYPTO_random_permute (GNUNET_CRYPTO_QUALITY_WEAK, count);
   q = GNUNET_CRYPTO_random_permute (GNUNET_CRYPTO_QUALITY_WEAK, count);