[GNUnet-SVN] r22380 - gnunet/src/namestore

[gnunet]

Author: grothoff
Date: 2012-06-29 14:46:11 +0200 (Fri, 29 Jun 2012)
New Revision: 22380

Modified:
   gnunet/src/namestore/gnunet-service-namestore.c
Log:
-check all fields for matches before removing

Modified: gnunet/src/namestore/gnunet-service-namestore.c
===================================================================
--- gnunet/src/namestore/gnunet-service-namestore.c     2012-06-29 12:25:58 UTC 
(rev 22379)
+++ gnunet/src/namestore/gnunet-service-namestore.c     2012-06-29 12:46:11 UTC 
(rev 22380)
@@ -1229,20 +1229,11 @@
   found = -1;
   for (c = 0; c < rd_count; c++)
   {
-    /* FIXME: shouldn't we test for all fields to match? Otherwise
-       we might remove the wrong record, just because the type matches! */
-    /*
-    if (rd[c].flags != rrc->rd->flags)
-       continue;*/
-    if (rd[c].record_type != rrc->rd->record_type)
-       continue;
-    /*
-    if (rd[c].data_size != rrc->rd->data_size)
-       continue;
-    GNUNET_break(0);
-    if (0 != memcmp (rd[c].data, rrc->rd->data, rrc->rd->data_size))
-        continue;
-    GNUNET_break(0); */
+    if ( (rd[c].flags != rrc->rd->flags) ||
+        (rd[c].record_type != rrc->rd->record_type) ||
+        (rd[c].data_size != rrc->rd->data_size) ||
+        (0 != memcmp (rd[c].data, rrc->rd->data, rrc->rd->data_size)) )
+      continue;
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Found record to remove!\n", 
rd_count);
     found = c;
     break;