[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gnugo-devel] Patch: new cache
|
From: |
Gunnar Farneback |
|
Subject: |
Re: [gnugo-devel] Patch: new cache |
|
Date: |
Tue, 05 Aug 2003 21:09:36 +0200 |
|
User-agent: |
EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.3 Emacs/20.7 (sparc-sun-solaris2.7) (with unibyte mode) |
Arend wrote:
> I've spotted another problem that I missed before: (in hash.c)
>
> static Hashvalue_ng komaster_hash[4]; /* EMPTY, BLACK, WHITE, GRAY */
> static Hashvalue_ng routine_hash[NUM_ROUTINES];
>
> [...]. The second isn't nice because it means
> that hash.c has to include cache.h (where NUM_ROUTINES is defined).
> (Which currently happens by including liberty.h.)
More importantly the routine stuff shouldn't be in hash.c at all as
that has nothing to do with the board while hash.c is part of
libboard. Instead it should go into cache.c.
/Gunnar