Re: [gnugo-devel] Patch: Better valuation of attack threats

[Inge Wallin]

Gunnar wrote:
> There are things in this patch making me very nervous.

Right.  This patch has to be revised.

> > +  color = OTHER_COLOR(board[ww]);
> > +  if (!trymove(pos, color, "adjusted_worm_attack_threat_value", ww,
> > +          NO_MOVE, NO_MOVE)) {
> > +    gg_assert(0);
> 
> Are you sure we don't risk an assertion failure here if the move is an
> illegal ko capture? I.e. are you sure that case can't happen?

no.  I will fix that.

> It's looking at both the dragon and the worm arrays, but those are not
> generally valid when stackp > 0. It IS possible to use them, but it
> requires much care. Here it seems to me that the trymove() may have
> 1. Introduced a new neighbor string of ww, which will be found by
>    chainlinks().
> 2. Moved the origin of one the existing neighbors. This new origin
>    will be returned by chainlinks().
> 
> In both those cases dragon[adj] and worm[adj] will contain invalid
> data.

Right again. I will fix this too.

> /Gunnar
> 
> _______________________________________________
> gnugo-devel mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/gnugo-devel
>