[gnuastro-devel] [bug #54430] BuildProgram fails with older Libtool versions on dash

[Mohammad Akhlaghi]

URL:
  <http://savannah.gnu.org/bugs/?54430>

                 Summary: BuildProgram fails with older Libtool versions on
dash
                 Project: GNU Astronomy Utilities
            Submitted by: makhlaghi
            Submitted on: Thu 02 Aug 2018 03:32:28 PM CEST
                Category: BuildProgram
                Severity: 3 - Normal
              Item Group: Crash
                  Status: In Progress
                 Privacy: Public
             Assigned to: makhlaghi
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Some operating systems (Ubuntu in this case) set the default shell to dash
<https://wiki.archlinux.org/index.php/Dash>, it is a minimalist POSIX
compliant shell. Therefore it doesn't have many features that are available in
Bash (including the `+=' operator). 

Older versions of Libtool (2.4.2 in this case) don't check for the
availability of the `+=' operator by the shell before using it, therefore
BuildProgram fails on such systems with an error like this:


/home/userid/anaconda2/bin/libtool: 1581: /home/userid/anaconda2/bin/libtool:
preserve_args+= --tag CC: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= -Wall: not found
/home/userid/anaconda2/bin/libtool: 6434: /home/userid/anaconda2/bin/libtool:
compile_command+= -Wall: not found
/home/userid/anaconda2/bin/libtool: 6435: /home/userid/anaconda2/bin/libtool:
finalize_command+= -Wall: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= -O3: not found
/home/userid/anaconda2/bin/libtool: 6298: /home/userid/anaconda2/bin/libtool:
compile_command+= -O3: not found
/home/userid/anaconda2/bin/libtool: 6299: /home/userid/anaconda2/bin/libtool:
finalize_command+= -O3: not found
/home/userid/anaconda2/bin/libtool: 6300: /home/userid/anaconda2/bin/libtool:
compiler_flags+= -O3: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= -I../lib: not found
/home/userid/anaconda2/bin/libtool: 6434: /home/userid/anaconda2/bin/libtool:
compile_command+= -I../lib: not found
/home/userid/anaconda2/bin/libtool: 6435: /home/userid/anaconda2/bin/libtool:
finalize_command+= -I../lib: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= -I../lib/: not found
/home/userid/anaconda2/bin/libtool: 6434: /home/userid/anaconda2/bin/libtool:
compile_command+= -I../lib/: not found
/home/userid/anaconda2/bin/libtool: 6435: /home/userid/anaconda2/bin/libtool:
finalize_command+= -I../lib/: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= ../tests/buildprog/simpleio.c: not found
/home/userid/anaconda2/bin/libtool: 6434: /home/userid/anaconda2/bin/libtool:
compile_command+= ../tests/buildprog/simpleio.c: not found
/home/userid/anaconda2/bin/libtool: 6435: /home/userid/anaconda2/bin/libtool:
finalize_command+= ../tests/buildprog/simpleio.c: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= -I/usr/local/include: not found
/home/userid/anaconda2/bin/libtool: 6434: /home/userid/anaconda2/bin/libtool:
compile_command+= -I/usr/local/include: not found
/home/userid/anaconda2/bin/libtool: 6435: /home/userid/anaconda2/bin/libtool:
finalize_command+= -I/usr/local/include: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= ../lib/libgnuastro.la: not found
/home/userid/anaconda2/bin/libtool: 6418: /home/userid/anaconda2/bin/libtool:
deplibs+= ../lib/libgnuastro.la: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= -o: not found
/home/userid/anaconda2/bin/libtool: 6434: /home/userid/anaconda2/bin/libtool:
compile_command+= -o: not found
/home/userid/anaconda2/bin/libtool: 6435: /home/userid/anaconda2/bin/libtool:
finalize_command+= -o: not found
/home/userid/anaconda2/bin/libtool: 5656: /home/userid/anaconda2/bin/libtool:
libtool_args+= simpleio: not found
/home/userid/anaconda2/bin/libtool: 5662: /home/userid/anaconda2/bin/libtool:
compile_command+= @OUTPUT@: not found
/home/userid/anaconda2/bin/libtool: 5663: /home/userid/anaconda2/bin/libtool:
finalize_command+= @OUTPUT@: not found
/home/userid/anaconda2/bin/libtool: 9202: /home/userid/anaconda2/bin/libtool:
compile_command+= : not found
/home/userid/anaconda2/bin/libtool: 9203: /home/userid/anaconda2/bin/libtool:
finalize_command+= : not found
libtool: link: gcc
gcc: fatal error: no input files
compilation terminated.

Compiling and linking the program
---------------------------------
/home/userid/Downloads/gnuastro-0.6.54-6aa5/bin/buildprog/.libs/lt-astbuildprog:
failed to build, see libtool error above
FAIL buildprog/simpleio.sh (exit status: 1)


Newer versions of libtool do address this problem (checked with version
2.4.6), but we don't want to force the user to modify their installation as
much as possible: only if there is no other way.

So a check should be written to see if Libtool works within the system's
default shell. If it doesn't, then we'll check if Bash is present. If it
indeed works with Bash (older versions of Bash also don't support the `+='
operator), then we'll put a `bash -c' behind the command called by
BuildProgram to fix the problem on such systems.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54430>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/