[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnuastro-commits] master 7c83a2b 2/3: Corrected problem in dependency m
From: |
Mohammad Akhlaghi |
Subject: |
[gnuastro-commits] master 7c83a2b 2/3: Corrected problem in dependency missing message at configure time |
Date: |
Thu, 13 Sep 2018 14:27:51 -0400 (EDT) |
branch: master
commit 7c83a2b0a2d15f936f53626d6e8b787798e05b8b
Author: Mohammad Akhlaghi <address@hidden>
Commit: Mohammad Akhlaghi <address@hidden>
Corrected problem in dependency missing message at configure time
We were mistakenly using the `-L' flag for `CPPFLAGS' in the message that
the configure script prints when a mandatory dependency is missing, causing
the suggested commands to not work. It is corrected in this commit along
with some small edits to make it more clear and easy to read.
This bug was found by Mamta Pommier.
---
THANKS | 1 +
configure.ac | 7 ++++---
doc/announce-acknowledge.txt | 1 +
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/THANKS b/THANKS
index f55b913..6a6ea2a 100644
--- a/THANKS
+++ b/THANKS
@@ -50,6 +50,7 @@ support in Gnuastro. The list is ordered alphabetically (by
family name).
Dmitrii Oparin address@hidden
Bertrand Pain address@hidden
William Pence address@hidden
+ Mamta Pommier address@hidden
Bob Proulx address@hidden
Teymoor Saifollahi address@hidden
Yahya Sefidbakht address@hidden
diff --git a/configure.ac b/configure.ac
index 19c2d1b..7054dec 100644
--- a/configure.ac
+++ b/configure.ac
@@ -318,13 +318,14 @@ AS_IF([test "x$missing_mandatory" = "xyes"],
AS_ECHO(["LD_LIBRARY_PATH environment variables before running
configure. For example"])
AS_ECHO(["with the following commands (just correct the
\`/install/path' part)."])
AS_ECHO([" $ export LDFLAGS=\"\$LDFLAGS -L/install/path/lib\""])
- AS_ECHO([" $ export CPPFLAGS=\"\$CPPFLAGS -L/install/path/include\""])
+ AS_ECHO([" $ export CPPFLAGS=\"\$CPPFLAGS -I/install/path/include\""])
AS_ECHO([" $ export
LD_LIBRARY_PATH=\"\$LD_LIBRARY_PATH:/install/path/lib\""])
- AS_ECHO(["[TIP] Put these commands in your startup file (for example
\`~/.bashrc') to"])
+ AS_ECHO([""])
+ AS_ECHO(["[TIP:] Put these commands in your startup file (for example
\`~/.bashrc') to"])
AS_ECHO(["avoid similar problems later. See the link below to learn
more:"])
AS_ECHO(["
https://www.gnu.org/software/gnuastro/manual/html_node/Installation-directory.html"])
AS_ECHO([""])
- AC_MSG_ERROR([Mandatory dependency(s) missing, see above.])
+ AC_MSG_ERROR([Mandatory dependency(s) missing, === SEE MESSAGE ABOVE
===.])
])
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index e8e934a..6d507b9 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -2,4 +2,5 @@ Alphabetically ordered list to acknowledge in the next release.
Pierre-Alain Duc
Gaspar Galaz
+Mamta Pommier
Michael Stein