[gnuastro-commits] master 4e2ab00 2/2: Removed extra freeing when changing values in ConvertType

[Mohammad Akhlaghi]

branch: master
commit 4e2ab00a9652e97dbcef5582619197444d054d60
Author: Mohammad Akhlaghi <address@hidden>
Commit: Mohammad Akhlaghi <address@hidden>

    Removed extra freeing when changing values in ConvertType
    
    To change values, ConvertType uses the arithmetic library. The flags that
    are passed to the library include `GAL_ARITHMETIC_FREE'. So any temporary
    arrays are freed by the library. However, we were mistakenly freeing one
    temporary array (`cond') separately afterwards. This resulted in a
    segmentation fault. So the freeing of `cond' is now removed.
    
    This bug was found thanks to Takashi Ichikawa.
    
    This fixes bug #52010.
---
 NEWS                         | 17 +++++++++++++++++
 bin/convertt/convertt.c      |  1 -
 doc/announce-acknowledge.txt |  2 ++
 3 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 8aa498d..f58fc93 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,22 @@
 GNU Astronomy Utilities NEWS                          -*- outline -*-
 
+
+* Noteworthy changes in release 0.4.XXX (library 2.0.0) (YYYY-MM-DD) [stable]
+
+** New features
+
+** Removed features
+
+** Changed features
+
+** Bug fixes
+
+  ConvertType crash when changing values (bug #52010).
+
+
+
+
+
 * Noteworthy changes in release 0.4 (library 2.0.0) (2017-09-13) [stable]
 
 ** New features
diff --git a/bin/convertt/convertt.c b/bin/convertt/convertt.c
index 729811a..88df4d0 100644
--- a/bin/convertt/convertt.c
+++ b/bin/convertt/convertt.c
@@ -79,7 +79,6 @@ convertt_change(struct converttparams *p)
 
         /* Clean up, since we set the free flag, all extra arrays have been
            freed.*/
-        gal_data_free(cond);
         gal_data_free(change->from);
       }
 
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index 18c7a2c..b76e5bb 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -1,2 +1,4 @@
 This file is meant to keep the names of the people who's help must be
 acknowledged in the next release.
+
+Takashi Ichikawa