[Gnu-arch-users] Re: [PATCH] Re: bazaar bug #385 (Re: Stabilizing Bazaar?)

[Robert Widhopf-Fenk]

On Tuesday, May 24, 2005 at 00:47:38, Robert Widhopf-Fenk wrote:
> On Monday, May 23, 2005 at 20:51:49, Matthieu Moy wrote:
> > Robert Collins <address@hidden> writes:
> > 
> > > Anyway, I've added a check to arch_find_local_tree_copy (which
> > > all reference tree lookups go though) to validate the tree
> > > metadata. If the tree does not match what we expected (both
> > > revision and default-version) then its removed and a new one
> > > created.
> > 
> > Good. Robert (Widhopf-Fenk), can you try the latest revision of
> > the official baz 1.4?
> 
> I'll do it when finding time.

Finally I did some debugging.

My problem comes from a call to arch_archive_connect_branch
within arch_build_revision.   It was called for an archive
which I did not register and thus returned NULL.

Cheers Robert

int
arch_build_revision (t_uchar const * const dest_dir,
                     struct arch_archive * arch,
                     t_uchar const * const archive, 
                     t_uchar const * const revision,
                     arch_project_tree_t * cache)
{
  struct arch_archive * my_arch = talloc_reference (NULL, arch);
  arch_patch_id * revision_patch = arch_patch_id_new_archive (archive, 
revision);
  int from_library = 0;
  int n_patches;
  if (!my_arch)
    // call with unregistered archive 
    my_arch = arch_archive_connect_branch(archive, NULL);
  
  invariant (my_arch != NULL);